Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: less than char validation #739

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

Jshhhh
Copy link
Contributor

@Jshhhh Jshhhh commented Oct 31, 2022

Issue #, if available:

Description of changes:

  • Change < char validation to <=

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jshhhh Jshhhh requested a review from a team as a code owner October 31, 2022 23:54
@codecov-commenter
Copy link

Codecov Report

Merging #739 (20ed293) into tagged-release/forms-hotfix (369e7a9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           tagged-release/forms-hotfix     #739   +/-   ##
============================================================
  Coverage                        91.32%   91.32%           
============================================================
  Files                              102      102           
  Lines                             3998     3998           
  Branches                          1116     1116           
============================================================
  Hits                              3651     3651           
  Misses                             325      325           
  Partials                            22       22           
Impacted Files Coverage Δ
...ges/codegen-ui-react/lib/utils/forms/validation.ts 97.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 369e7a9...20ed293. Read the comment docs.

@Jshhhh Jshhhh merged commit c0ee240 into tagged-release/forms-hotfix Nov 1, 2022
@Jshhhh Jshhhh deleted the lessthan-validation branch November 1, 2022 00:15
Jshhhh added a commit that referenced this pull request Nov 3, 2022
Co-authored-by: Justin Shih <jushih@amazon.com>
Jshhhh added a commit that referenced this pull request Nov 3, 2022
Co-authored-by: Justin Shih <jushih@amazon.com>
@Jshhhh Jshhhh mentioned this pull request Nov 3, 2022
hein-j pushed a commit that referenced this pull request Nov 3, 2022
Co-authored-by: Justin Shih <jushih@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants