Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Go project with multiple files #13765

Merged
merged 1 commit into from
May 6, 2024

Conversation

0618
Copy link
Contributor

@0618 0618 commented May 6, 2024

Description of changes

After https://github.com/aws-amplify/amplify-cli/pull/13671/files#diff-9e8ed84544b6574832f1d34bde8bc4fffff3558a54806adb09b4884758ff618aR105, Go project would fail if it has more functions than main.go.

To fix it, we need to build all Go files instead of only main.go.

Special thanks to @ykethan for diving into this issue.

Issue #, if available

#13725

Description of how you validated changes

verified with my local test project.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@0618 0618 marked this pull request as ready for review May 6, 2024 22:30
@0618 0618 requested a review from a team as a code owner May 6, 2024 22:30
@0618 0618 merged commit bd5dc93 into aws-amplify:dev May 6, 2024
5 checks passed
@0618 0618 deleted the fix-go-issue-13725 branch May 7, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants