feat(api): allow ${env} reference in custom-roles.json #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @joekiller overall looks good, could you undo your changes to the yarn.lock? We'll manage yarn.lock changes separately |
joekiller
force-pushed
the
category-auth/allow-env-reference-in-custom-role-file
branch
from
f54309e to
d11e788
Compare
|
@marcvberg I have removed the yarn.lock changes |
marcvberg
reviewed
Sep 19, 2022
|
@marcvberg anything else I can do here? this feature would be useful for my team already :) |
|
@marcvberg, @sundersc, or @alharris-at seems the docs have shipped but this has yet to merge. |
|
Hi @joekiller, just committed an additional merge conflict change, and reviewing this PR now. Also kicking off e2e tests, if those all look good, we'll get this merged in. Thank you for following up. |
alharris-at
previously approved these changes
Mar 21, 2023
alharris-at
approved these changes
Mar 21, 2023
AaronZyLee
approved these changes
Mar 21, 2023
joekiller
deleted the
category-auth/allow-env-reference-in-custom-role-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Allow using
${env}in custom-roles.json to reference the current Amplify CLI environment.Also lint --fix was applied.
Issue #, if available
Documentation update: aws-amplify/docs#4591
Description of how you validated changes
Added tests.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.