fix: disable waiter state machine logging that results in deploy error #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpilch
changed the title
dpilch
commented
Jan 12, 2024
| @@ -25,7 +25,7 @@ describe('v1 to v2 migration', () => { | |||
| const v1nestedStackNames = Object.keys(v1result.stacks).filter((stackName) => stackName !== 'ConnectionStack'); // The v1 transformer puts all connection resolvers in a 'ConnectionStack'. This stack does not define any data resources | |||
|
|
|||
| // verify root stack diff | |||
| const diff = cdkDiff.diffTemplate(v1result.rootStack, v2result.rootStack); | |||
There was a problem hiding this comment.
Breaking change with version upgrade: aws/aws-cdk#28336
diffTemplate is no longer exported, but fullDiff seems to just be a wrapper.
|
The version upgrade will also require moving to Jest 27: jestjs/jest#11331 |
sundersc
previously approved these changes
Jan 12, 2024
phani-srikar
previously approved these changes
Jan 12, 2024
AaronZyLee
previously approved these changes
Jan 13, 2024
sundersc
previously approved these changes
Jan 13, 2024
phani-srikar
previously approved these changes
Jan 13, 2024
phani-srikar
previously approved these changes
Jan 13, 2024
sundersc
previously approved these changes
Jan 13, 2024
svidgen
previously approved these changes
Jan 13, 2024
dpilch
dismissed stale reviews from svidgen, sundersc, and phani-srikar
via
c84d01b
svidgen
previously approved these changes
Jan 13, 2024
phani-srikar
previously approved these changes
Jan 13, 2024
AaronZyLee
approved these changes
Jan 16, 2024
4 tasks
sundersc
approved these changes
Jan 17, 2024
iartemiev
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Attempting to deploy in later versions of CDK result in error:
This change upgrades our dependencies to the latest CDK Lib version so that we can utilize an option to disable logging on the state machine.
See https://github.com/aws-amplify/amplify-category-api/pull/2196/files#diff-2f1007f7f1c64b1c31c5f33e3efef71fa74eb48019015e14154109e08faae65e.
CDK / CloudFormation Parameters Changed
Upgrade to CDK version ^2.120.0.
Issue #, if available
N/A
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.