add e2e test project reset and add reset to hotswap retries #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtpascual
added
the
run-e2e
🦋 Changeset detectedLatest commit: 1c9ecb5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sobolk
approved these changes
Dec 31, 2024
| async () => { | ||
| // keeping initial deployment in retry loop to reset app state for each hotswap to be a non no-op | ||
| async (attempt) => { | ||
| if (attempt > 1) { |
There was a problem hiding this comment.
nit: we could skip this if. reset of fresh project is no-op.
this is more explicit though so feel free to disregard.
There was a problem hiding this comment.
That's true but I preferred being more explicit here so the project doesn't reset when it doesn't need to on first attempt of hotswap.
Amplifiyer
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When performing retries of hotswapping resources in sandbox E2E tests, we are not bringing the test project back to pre-update state (without the updated files) for each retry.
Issue number, if available:
Changes
Add
resetmethod toTestProjectBasewhich does the following:amplifydirectoryamplifydirectory to the emptied projectamplifydirectorypackage.jsonandtsconfig.jsonin the project'samplifydirectory again (since they were removed from step 1).Use
testProject.reset()for retries of hotswapping resources.Corresponding docs PR, if applicable:
Validation
E2E tests
Checklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.