Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: custom runtimes to define function #1602
base: main
Are you sure you want to change the base?
Feature: custom runtimes to define function #1602
Changes from 2 commits
49abcbd
dbdccba
26ea2f2
9f6f2e4
cefa084
53b475f
89b52d4
497da33
70db088
cbaa8bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following up on my overall comment, I'm not sure how we're going to handle environment variables of type
Record<string, string | BackendSecret>;
. (see line 88 of this file) I see that you can add an environment variable viaaddEnvironment(key: string, value: string, options?: EnvironmentOptions): this;
method ofPythonFunction
. However, thevalue
cannot be of typeBackendSecret
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarlonJD @arash2060 I am so excited to see this functionality so close! I am new to Amplify and have been enjoying the ease of development...but got hung up royally today trying to figure out how to add a custom query to my graphql schema via a lambda with python 3_11 runtime. This functionality will be well-used and loved as I build out slew of microservices that use LangChain. I am wondering if you would consider deploying without supporting environment variables for now as a way to get this into our hands. From my understanding, that would require adding a permission for the lambda to access the secret store with boto3 and a warning about the additional cost and latency while the full functionality is being built out. Is this feasible? Curious to hear your thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! If you want to auto deploy with amplify we should use AWS Secret Manager, it's because
secret('foo')
using this, you can easily use .env file and manuel deploy without this I can give an example for this, if you have another solution or idea please tell me mayne we can build, I'm thinking publish my amplify fork and use this on amplify auto deploy because of limit issue and this python and golang functions, I'll share with you this examples here If you want to use custom functions on auto build in amplify console.