fix: use propagateTags service value #712
Draft
+23,451
−85,242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guikcd
force-pushed
the
propagate_tags_get_current_value
branch
5 times, most recently
from
98e4b5b to
70acf97
Compare
guikcd
force-pushed
the
propagate_tags_get_current_value
branch
from
70acf97 to
150d0a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #707
Without this PR, if propagate-tags is set to
NONEif user don't set it.This overwrite the service propagateTags and this is a problem when it's set to SERVICE or TASK_DEFINITION (in IaC typically).
This PR first describe the service to get the value of the existing propagateTags value. If no value is set in the action yaml, take this value.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.