Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shape: Add a "solid shadow" shape. #3489

Merged
merged 1 commit into from
Oct 16, 2022
Merged

Conversation

Elv13
Copy link
Member

@Elv13 Elv13 commented Oct 29, 2021

Credit to @actionless for originally using it in some of his themes.

image

In my case, I originally wrote it for this MS-DOS homage demo https://imgur.com/a/8ikCPl0

I upstream it now because it got some little interest in the chat.

This is an useful client shape to get "client side solid shadows".
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #3489 (9797e47) into master (1e0d1e7) will decrease coverage by 0.01%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##           master    #3489      +/-   ##
==========================================
- Coverage   90.25%   90.24%   -0.02%     
==========================================
  Files         822      823       +1     
  Lines       53561    53600      +39     
==========================================
+ Hits        48341    48370      +29     
- Misses       5220     5230      +10     
Flag Coverage Δ
gcov 90.24% <95.00%> (-0.02%) ⬇️
luacov 93.30% <95.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/gears/shape.lua 97.87% <93.93%> (-0.38%) ⬇️
...ts/examples/gears/shape/solid_rectangle_shadow.lua 100.00% <100.00%> (ø)
event.c 71.94% <0.00%> (-1.21%) ⬇️
lib/wibox/widget/imagebox.lua 94.64% <0.00%> (-0.90%) ⬇️
spawn.c 86.09% <0.00%> (-0.07%) ⬇️

@actionless
Copy link
Member

i wonder how it could be used for that practically?

in my case the client just had 4 titlebars and each of them was handling drawing 1/4 of the shape on its own

Copy link
Member

@Aire-One Aire-One left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also fail to find a real word usage of this, but why not, if people ask for it 🤷

BTW, opening the discussion (again) : Maybe this kind of "very specific feature" should be distributed as third-party modules instead of being incorporated in the awesome code-base?

@actionless
Copy link
Member

i meant, from the point of code, how to set this shape to be a different-color shadow of the titlebar

@Elv13 Elv13 mentioned this pull request Feb 5, 2022
@Elv13
Copy link
Member Author

Elv13 commented Jun 30, 2022

@actionless The wibox.container.borders module in the PR above makes this more usable. While it's not merged yet[1], is that example use case enough to merge this now? It isn't a super huge change.

[1] (3rd item in my slowly progressing TODO list after fixing the CI and getting the doc reactor branch ready),

@Elv13 Elv13 merged commit 26032bf into awesomeWM:master Oct 16, 2022
@Elv13 Elv13 deleted the solid_shadow2 branch October 16, 2022 09:29
actionless pushed a commit to actionless/awesome that referenced this pull request May 6, 2023
This is an useful client shape to get "client side solid shadows".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants