-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shape: Add a "solid shadow" shape. #3489
Conversation
This is an useful client shape to get "client side solid shadows".
Codecov Report
@@ Coverage Diff @@
## master #3489 +/- ##
==========================================
- Coverage 90.25% 90.24% -0.02%
==========================================
Files 822 823 +1
Lines 53561 53600 +39
==========================================
+ Hits 48341 48370 +29
- Misses 5220 5230 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
i wonder how it could be used for that practically? in my case the client just had 4 titlebars and each of them was handling drawing 1/4 of the shape on its own |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also fail to find a real word usage of this, but why not, if people ask for it 🤷
BTW, opening the discussion (again) : Maybe this kind of "very specific feature" should be distributed as third-party modules instead of being incorporated in the awesome code-base?
i meant, from the point of code, how to set this shape to be a different-color shadow of the titlebar |
@actionless The [1] (3rd item in my slowly progressing TODO list after fixing the CI and getting the doc reactor branch ready), |
This is an useful client shape to get "client side solid shadows".
Credit to @actionless for originally using it in some of his themes.
In my case, I originally wrote it for this MS-DOS homage demo https://imgur.com/a/8ikCPl0
I upstream it now because it got some little interest in the chat.