Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for tabs and semicolons as delimiters #147

Merged
merged 7 commits into from
Feb 15, 2023

Conversation

abtsousa
Copy link
Contributor

@abtsousa abtsousa commented Feb 14, 2023

Automatically detect the database format using the CSV library's Sniffer class.

Closes #146

Copy link
Owner

@awdeorio awdeorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I really like the automatic format detection.

I pushed a couple of changes, take a look and see if this still works in your application.

  • Read a sample for automatic format detection instead of the whole database file
  • Add tests with TSV and semicolon-delimited databases
  • Fix failing tests

For the future, reviewing code is a little easier when you use a branch.

@abtsousa
Copy link
Contributor Author

Thank you so much for your changes, I'm self-taught and still learning the ropes on github so this will help me a lot on how to do things "properly". Everything is working on my end (tried tabs, commas and semicolons and all worked fine on a dry run).

Copy link
Contributor

@seshrs seshrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @abtsousa! And the changes so far look good @awdeorio :)

Copy link
Owner

@awdeorio awdeorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@awdeorio awdeorio merged commit 2284abb into awdeorio:develop Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CSV files with semicolons as separators
3 participants