-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for tabs and semicolons as delimiters #147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I really like the automatic format detection.
I pushed a couple of changes, take a look and see if this still works in your application.
- Read a sample for automatic format detection instead of the whole database file
- Add tests with TSV and semicolon-delimited databases
- Fix failing tests
For the future, reviewing code is a little easier when you use a branch.
Thank you so much for your changes, I'm self-taught and still learning the ropes on github so this will help me a lot on how to do things "properly". Everything is working on my end (tried tabs, commas and semicolons and all worked fine on a dry run). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Automatically detect the database format using the CSV library's
Sniffer
class.Closes #146