Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAIN security mode #139

Merged
merged 5 commits into from
Feb 15, 2023
Merged

PLAIN security mode #139

merged 5 commits into from
Feb 15, 2023

Conversation

piotrsz
Copy link

@piotrsz piotrsz commented Jan 24, 2022

Support older SMTP configuration with a password but without STARTTLS or SSL.

I had a really old SMTP configuration which I couldn't control. I was able to make it work with mailmerge by adding simple smtp.LOGIN. I hope that it's a valid contribution!

@awdeorio
Copy link
Owner

awdeorio commented Jan 24, 2022

This is great, thank you!

Would you be willing to make a couple of additions so that others can find your new feature?

EDIT: Please merge the latest upstream develop into your branch. I made some fixes to the continuous integration tests.

Copy link
Owner

@awdeorio awdeorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding a test and updating the sample server config.

@awdeorio awdeorio merged commit 578217d into awdeorio:develop Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants