Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency "html5 to "html5lib" #136

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

onuralpszr
Copy link
Contributor

@onuralpszr onuralpszr commented Oct 6, 2021

Mailmerge dependency html5 has been renamed to html5lib.

Closes #137

Change "html5" to html5lib
@awdeorio
Copy link
Owner

awdeorio commented Oct 7, 2021

Thanks for the contribution @thunderbirdtr ! It would be helpful if you could add an an issue that describes the problem. Then, fix the issue with this PR. At the very least, could you add a comment describing the problem?

@onuralpszr
Copy link
Contributor Author

@awdeorio issue opened and "comment" typed on the issue and this PR also edited and point to issue as well.

@awdeorio awdeorio changed the title Fixing, wrong deps "html5 to "html5lib" Update dependency "html5 to "html5lib" Oct 7, 2021
Copy link
Owner

@awdeorio awdeorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awdeorio
Copy link
Owner

awdeorio commented Oct 7, 2021

I made some updates upstream to fix recent linter errors (#138). Could you try merging in the latest upstream develop? I think that should get the tests passing.

@onuralpszr
Copy link
Contributor Author

@awdeorio ready to test.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

Merging #136 (d364e32) into develop (7146f27) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #136   +/-   ##
========================================
  Coverage    99.70%   99.70%           
========================================
  Files            5        5           
  Lines          344      344           
========================================
  Hits           343      343           
  Misses           1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7146f27...d364e32. Read the comment docs.

@awdeorio awdeorio merged commit a0eb63c into awdeorio:develop Oct 8, 2021
@awdeorio
Copy link
Owner

awdeorio commented Oct 8, 2021

I made a new release so you should be good to go with your downstream packaging @thunderbirdtr https://github.com/awdeorio/mailmerge/releases/tag/2.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup.py has "html5" but It has a new name "html5lib"
3 participants