-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency "html5 to "html5lib" #136
Conversation
Change "html5" to html5lib
Thanks for the contribution @thunderbirdtr ! It would be helpful if you could add an an issue that describes the problem. Then, fix the issue with this PR. At the very least, could you add a comment describing the problem? |
@awdeorio issue opened and "comment" typed on the issue and this PR also edited and point to issue as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I made some updates upstream to fix recent linter errors (#138). Could you try merging in the latest upstream |
@awdeorio ready to test. |
Codecov Report
@@ Coverage Diff @@
## develop #136 +/- ##
========================================
Coverage 99.70% 99.70%
========================================
Files 5 5
Lines 344 344
========================================
Hits 343 343
Misses 1 1 Continue to review full report at Codecov.
|
I made a new release so you should be good to go with your downstream packaging @thunderbirdtr https://github.com/awdeorio/mailmerge/releases/tag/2.2.1 |
Mailmerge dependency
html5
has been renamed tohtml5lib
.Closes #137