-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tar Cannot stat: No such file or directory #99
Comments
Can you turn on debug from the latest version and link to the logs? It is pulling in systemd as a dependency. It will try to tar all files in the APT manifest. For some reason that file is listed but not present on disk. We need to find out why that file isn't present. Once we know more we can either fix it per package or maybe accommodate in general (i.e. throw a warning and continue with Tar). I can get around to this but it may take me some time as I have been fairly busy recently. Something that would help a lot would be to install that version of systemd and see if the file is there, and try to explain the behavior. |
Yes, certainly. I'll try to make a minimal repo for reproducing it. One thing I noticed in the log is that |
I have created the minimal repo that reproduces the issue. It uses The failed job, along with the debug log can be read here: https://github.com/iver56/cache-apt-systemd/actions/runs/4374423862/jobs/7653831648 |
Thank you very much and the coffee 😁 The path will be relative intentionally because this is what Tar accepts only. I have it restore to root. I hope you have an update sometime today. |
You're welcome 😄
What kind of update from me do you want/expect? You mentioned "install that version of systemd and see if the file is there" earlier. Is that on me or you? How would one begin to reproduce it? Make a docker image where that version of systemd gets installed? |
This is on my end. You don't need to do anything more. I think I see what the issue is. The filename is using a backslash in it. $ ls /lib/systemd/system/system-*
'/lib/systemd/system/system-systemd\x2dcryptsetup.slice' Enclosed the filepath in single quotes and it was able to store and extract successfully. $ tar -cf /tmp/test.tar '/lib/systemd/system/system-systemd\x2dcryptsetup.slice' Working on a fix. Still need to clear some failing tests in |
Was able to clear up the errors and the regression test for this is now passing. You can try out the pre-release v1.3.0. Will do the final release later today (PST). |
Thanks! It seems to be working well on my end |
I'm not sure what happened or why, but I am now seeing this error once again, even with v1.3.0. I made a minimal reproduction here: Do you need me to enable debug mode as well? |
Wow, sorry to hear that. The regression isn't failing either. Does rolling back the version fix it? A debug run would be helpful. I noticed it failing on the same file but the backslash is gone which indicates some regression in my part. Try the run against master too in your action version as ...@master |
I tried v1.2.4 again, and that did not help: https://github.com/iver56/cache-apt-systemd/actions/runs/4686324193/jobs/8304282868?pr=3 Here is v1.3.0 with debug mode set to true: https://github.com/iver56/cache-apt-systemd/actions/runs/4686331941/jobs/8304299856?pr=4 And with |
Looks like the CI silently ate the error, which is why I didn't catch it originally. echo "lib/systemd/system/system-systemd\x2dcryptsetup.slice" | xargs -I '{}' echo \'{}\' Not sure how this ever worked actually as it was the only change a644619. Looks like Will work on an actual fix, then doublecheck on the CI and update here. |
Updated the CI regression test (old run log) with an updated version to see if it will trigger the error (awalsh128/cache-apt-pkgs-action-ci@f94c318). @iver56 do me a favor and run the action from the UPDATE: Actually hold off, looks like the change broke some other tests. |
Actually give it a shot. It is just do a package version not existing which I just need to debug on the CI end. |
Feel free to fork that |
Sorry for the delay. I'll check it out this weekend. |
@awalsh128 Hi there. I also get a very similar error:
And yes, |
Hmm, in my case, |
@iver56 I think I have fixed it: https://github.com/sn-o-w/cache-apt-systemd/actions/runs/5547482021/jobs/10129187070 We need this for the You can temporarily use |
Good work :) I have not tested it, but if it's a good fix, maybe it can be fixed upstream too? |
I started getting this same issue with the caching of systemd. Using @sn-o-w's branch fixes the issue. |
@awalsh128 Any chance @sn-o-w's fix can get merged upstream? |
Got this error tonight. @an-o-w's patch works. |
Pull in fix by @sn-o-w in https://github.com/sn-o-w/cache-apt-pkgs-action/commit/d0ee83b497ac30023e51cd526c62e57b07501912 mentioned in issue #99
* Pull dev upstream to staging. (#112) * Use awk to enclose filename in single quotes tar #99 * Add null field separator so filenames don't get broken up. * Move upload logs up in the action sequence so it captures data before it gets deleted. * Fix awk (#109) --------- Co-authored-by: sn-o-w <cristian.silaghi@mozilla.ro> * Fix awk delimiter. Pull in fix by @sn-o-w in https://github.com/sn-o-w/cache-apt-pkgs-action/commit/d0ee83b497ac30023e51cd526c62e57b07501912 mentioned in issue #99 --------- Co-authored-by: sn-o-w <cristian.silaghi@mozilla.ro>
Hi all. Lots of apologies for the massive delay. I updated the doc looking for help with maintainers (if any of you are feeling up to it). I integrated the fix and confirmed it works against the regression test on the CI (log). It is now available in release v1.3.1 and marked against latest tag. @iver56, @vvv and @sn-o-w, please confirm for yourself before I close this out. |
No need to apologize. I know the feeling. Thanks for merging, testing and releasing the fix! ❤️🥇 I just tested it, and it runs smoothly as far as I can tell. Now I can get fast CI runs again :D |
@awalsh128 It works! 🙌🏻 Thank you. |
) * Pull dev upstream to staging. (#112) * Use awk to enclose filename in single quotes tar #99 * Add null field separator so filenames don't get broken up. * Move upload logs up in the action sequence so it captures data before it gets deleted. * Fix awk (#109) --------- Co-authored-by: sn-o-w <cristian.silaghi@mozilla.ro> * Fix awk delimiter. Pull in fix by @sn-o-w in https://github.com/sn-o-w/cache-apt-pkgs-action/commit/d0ee83b497ac30023e51cd526c62e57b07501912 mentioned in issue #99 * Swap out Bash based APT query logic for Golang version. (#117) * First version of a Golang version of command handling in general. (#118) --------- Co-authored-by: sn-o-w <cristian.silaghi@mozilla.ro>
Hi,
I'm using cache-apt-pkgs-action (thanks for making it, by the way) like this:
Lately it has been failing. The log ends like this:
I have tried both latest (v1.2.4) and v1.2.1, and I get the same error in both cases. I have also tried execute_install_scripts: true
What can I do to resolve the issue?
The text was updated successfully, but these errors were encountered: