Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid using Base.identify_package without uuid #60

Merged
merged 1 commit into from
Jul 6, 2022
Merged

fix: avoid using Base.identify_package without uuid #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,25 +14,34 @@ Supported Benchmark Directories:
- `PKG_DIR/benchmark`

"""
benchmark_dir(pkg::Module) = benchmark_dir(Base.PkgId(pkg))
benchmark_dir(pkg::Symbol) = benchmark_dir(Base.PkgId(string(pkg)))
benchmark_dir(pkg::Module) = benchmark_dir(pkgdir(pkg))
function benchmark_dir(pkg::Symbol)
pkg_id = Base.identify_package(string(pkg))
@assert !isnothing(pkg_id) "Could not identify the package: $pkg"
benchmark_dir(pkg_id)
end
function benchmark_dir(pkg_id::Base.PkgId)
pkg_dir = joinpath(dirname(Base.locate_package(pkg_id)), "..")
entry_point = Base.locate_package(pkg_id)
@assert !isnothing(entry_point) "Could not locate the package: $pkg_id"
pkg_dir = joinpath(entry_point, "..", "..")
benchmark_dir(pkg_dir)
end
function benchmark_dir(pkg_dir::String)
joinpath(pkg_dir, "benchmark") |> abspath
end
function benchmark_dir(pkg::Pkg.Types.PackageSpec)
# Locate packages location from a PackageSpec
if pkg.path !== nothing
pkg_path = pkg.path
elseif pkg.repo.source !== nothing
pkg_path = pkg.repo.source
if !isnothing(pkg.path)
return benchmark_dir(pkg.path)
elseif !isnothing(pkg.repo.source)
return benchmark_dir(pkg.repo.source)
elseif ~isnothing(pkg.name) && ~isnothing(pkg.uuid)
return benchmark_dir(Base.PkgId(pkg.uuid, pkg.name))
elseif ~isnothing(pkg.name)
return benchmark_dir(Symbol(pkg.name))
else
error("Unable to locate $pkg")
end
benchmark_dir(pkg_path)
end

"""
Expand Down