Avoid null reference when max size is 1 #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when max size was 1, any additions after the first one would fail with > TypeError: Cannot set property 'prev' of null because the `evict` function did not expect there could be nothing left in the cache once the evicted item was removed. This change makes the `evict` more robust in cases like that.
avoidwork
added a commit
that referenced
this pull request
Feb 13, 2022
|
Closing this PR and handling the other attribute with #50. |
|
This is fixed in 8.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when max size was 1, any additions after the first one
would fail with
because the
evictfunction did not expect there could be nothing leftin the cache once the evicted item was removed.
This change makes the
evictmore robust in cases like that.Inspired by the previous PRs, I split the rebuild into a separate commit.