Fixing a regression of limit() by switching to [].slice()

avoidwork · Oct 27, 2016 · 2c76e4b · 2c76e4b
1 parent 37eaac5
commit 2c76e4b
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 14 deletions.
diff --git a/lib/haro.es6.js b/lib/haro.es6.js
@@ -5,7 +5,7 @@
  * @copyright 2016
  * @license BSD-3-Clause
  * @link https://github.com/avoidwork/haro
- * @version 3.0.2
+ * @version 3.0.3
  */
 "use strict";
 
@@ -668,9 +668,10 @@ class Haro {
 	}
 
 	limit (offset = 0, max = 0, raw = false) {
-		let result = this.registry.slice(offset, max).map(i => {
-			return this.get(i, raw);
-		});
+		const end = offset + max,
+			result = this.registry.slice(offset, end).map(i => {
+				return this.get(i, raw);
+			});
 
 		return !raw ? tuple.apply(tuple, result) : result;
 	}
@@ -1251,7 +1252,7 @@ function factory (data = null, config = {}, indexes = []) {
 }
 
 factory.transform = cast;
-factory.version = "3.0.2";
+factory.version = "3.0.3";
 
 // Node, AMD & window supported
 if (typeof exports !== "undefined") {

diff --git a/lib/haro.js b/lib/haro.js
@@ -5,7 +5,7 @@
  * @copyright 2016
  * @license BSD-3-Clause
  * @link https://github.com/avoidwork/haro
- * @version 3.0.2
+ * @version 3.0.3
  */
 "use strict";
 
@@ -738,7 +738,8 @@ function _classCallCheck(instance, Constructor) { if (!(instance instanceof Cons
 				var max = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : 0;
 				var raw = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : false;
 
-				var result = this.registry.slice(offset, max).map(function (i) {
+				var end = offset + max,
+				    result = this.registry.slice(offset, end).map(function (i) {
 					return _this5.get(i, raw);
 				});
 
@@ -1412,7 +1413,7 @@ function _classCallCheck(instance, Constructor) { if (!(instance instanceof Cons
 	}
 
 	factory.transform = cast;
-	factory.version = "3.0.2";
+	factory.version = "3.0.3";
 
 	// Node, AMD & window supported
 	if (typeof exports !== "undefined") {