Test subprocess improvements #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are using signals as a form of IPC (inter process communication), let's use SIGUSR1, which is a user defined signal that won't be easily mistaken with the more common SIGTERM, that can be issued far more commonly. Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
|
Great , LGTM. |
Closed
Closed
Closed
This was referenced Jul 19, 2023
Closed
Merged
This was referenced Aug 8, 2023
Closed
Merged
This was referenced Aug 22, 2023
This was referenced Sep 6, 2023
This was referenced Nov 28, 2023
Merged
This was referenced Dec 6, 2023
Merged
This was referenced Dec 13, 2023
This was referenced Dec 21, 2023
Merged
This was referenced Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use SIGUSR1 instead of SIGTERM, also, wait on the process queue instead of waiting on the process.