Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check-lint hides errors from all but last run #11

Closed
clebergnu opened this issue Oct 2, 2024 · 0 comments
Closed

check-lint hides errors from all but last run #11

clebergnu opened this issue Oct 2, 2024 · 0 comments
Assignees
@harvey0100
Labels
bug Something isn't working

Comments

@clebergnu
Copy link
Contributor

Because check-lint implements the execution of pylint on possibly multiple different files (controlled by the avocado-static-checks.conf file), it needs to keep track of all failures.

Currently, the exit code of the script is simply the exit code of the last command executed.
@clebergnu clebergnu added the bug Something isn't working label Oct 2, 2024
@clebergnu clebergnu changed the title check-lint hides errors from all but last runs check-lint hides errors from all but last run Oct 2, 2024
@mr-avocado mr-avocado bot moved this to Triage in Default project Oct 2, 2024
@clebergnu clebergnu mentioned this issue Oct 2, 2024
Open
@harvey0100 harvey0100 self-assigned this Oct 2, 2024
harvey0100 added a commit to harvey0100/avocado-static-checks that referenced this issue Oct 4, 2024
@harvey0100
Pylint Error Handling
7e8bdcd 
Corrected error handling, check-lint now displays
correct exit codes on exit instead of only displaying
the last executed commands exit code, keeps track of all failures
and displays correct exit code if any failures were present.

Reference:     avocado-framework#11
Signed-off-by: Harvey Lynden <hlynden@redhat.com>
@harvey0100 harvey0100 mentioned this issue Oct 4, 2024
Merged
harvey0100 added a commit to harvey0100/avocado-static-checks that referenced this issue Oct 4, 2024
@harvey0100
Pylint Error Handling
f6fd2de 
Corrected error handling, check-lint now displays
correct exit codes on exit instead of only displaying
the last executed commands exit code, keeps track of all failures
and displays correct exit code if any failures were present.

Reference:     avocado-framework#11
Signed-off-by: Harvey Lynden <hlynden@redhat.com>
harvey0100 added a commit to harvey0100/avocado-static-checks that referenced this issue Oct 10, 2024
@harvey0100
Pylint Error Handling
30f0a18 
Corrected error handling, check-lint now displays
correct exit codes on exit instead of only displaying
the last executed commands exit code, keeps track of all failures
and displays correct exit code if any failures were present.

Reference:     avocado-framework#11
Signed-off-by: Harvey Lynden <hlynden@redhat.com>
@richtja richtja moved this from In progress to Done 109 in Default project Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harvey0100 harvey0100

Labels
bug Something isn't working
Projects
Default project
Status: Done 109
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clebergnu @harvey0100