Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add back button to association pages #3096

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Conversation

binarygit
Copy link
Contributor

@binarygit binarygit commented Aug 6, 2024

Description

This PR adds a back button when association pages are opened in their own window.

Fixes #3061

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

2024-08-06.16-17-02.mp4

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link

codeclimate bot commented Aug 6, 2024

Code Climate has analyzed commit 8adac91 and detected 0 issues on this pull request.

View more on Code Climate.

@binarygit binarygit marked this pull request as ready for review August 6, 2024 10:45
Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We spoke about this

  • another feature test using turbo request to test the oposite
  • search for the back button in the data-target="panel-tools" div

Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add that comment we spoke about.

Thanks Avi!

@Paul-Bob Paul-Bob merged commit 57325c3 into main Aug 9, 2024
21 of 22 checks passed
@Paul-Bob Paul-Bob deleted the add-back-button branch August 9, 2024 08:10
Copy link
Contributor

github-actions bot commented Aug 9, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add back button to has_many association when viewed not as a turbo request
3 participants