-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add back button to association pages #3096
Conversation
Code Climate has analyzed commit 8adac91 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We spoke about this
- another feature test using turbo request to test the oposite
- search for the back button in the
data-target="panel-tools"
div
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add that comment we spoke about.
Thanks Avi!
d449ad2
to
8adac91
Compare
This PR has been merged into Please check the release guide for more information. |
Description
This PR adds a back button when association pages are opened in their own window.
Fixes #3061
Checklist:
Screenshots & recording
2024-08-06.16-17-02.mp4
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.