Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple tables scaling incorrectly #536

Conversation

LunarN0va
Copy link
Contributor

@LunarN0va LunarN0va commented Jun 13, 2024

This PR sets the table layout to fixed whenever a table has more than two columns. I'd love to hear your thoughts on this change.

Before:
Screenshot 2024-06-13 at 16 06 22

After:
Screenshot 2024-06-13 at 11 34 34

Tables with less than two columns don't have a fixed table layout:
Screenshot 2024-06-13 at 16 08 13

But if this needs to change: this is what it would look like if the same table has a fixed table layout:
Screenshot 2024-06-13 at 11 34 40

@jp7677
Copy link
Contributor

jp7677 commented Jun 17, 2024

I think this is a pretty good work around, but still somewhat fragile ;). I guess the decisions page (https://avisi-cloud.github.io/structurizr-site-generatr/main/internet-banking-system/decisions/) is still a but off with this PR.

I think a better and more consistent approach might be to handle a fixed percentage per column type. So e,g. give all columns with the name ID, Date and Status a width of 20%, columns for Systems, Technology and Name a width of 30%. Other columns might not need a set width.

@jenspav jenspav mentioned this pull request Jul 2, 2024
@jp7677
Copy link
Contributor

jp7677 commented Jul 3, 2024

Superseded by #553

@jp7677 jp7677 closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants