Add the ability to set the target for links in the SVG file. #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is only affects the SVG file output.
|
Hi @qtzar, thanks for your PR. I'm surprised that the PlantUML export uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the PlantUML export to SVG set all links with
target="_top"which is causing havoc when you want to embed the generated site in an iFrame.This PR adds a new option to the View Properties called
generatr.svglink.targetthat will allow you to override this default with something like_selfor any other string. Custom strings are allowed because iFrames can be permitted to have an id which a link target can reference.If the new property is not set then the current default behavior of
_topis maintained.