Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalidate internal code cache anyway when JET hasn't analyzed it yet #58

Merged
merged 6 commits into from
Oct 29, 2020

Conversation

aviatesk
Copy link
Owner

this will of course slow down analysis peformance, but should give us
more correct analysis

it reveals the truth of lots of hidden false positives though ...

@aviatesk aviatesk force-pushed the avi/morecorrectcache branch 6 times, most recently from 6465354 to 6c3e9d5 Compare October 21, 2020 09:42
@aviatesk aviatesk force-pushed the avi/morecorrectcache branch 2 times, most recently from 4eb2bcc to efc749b Compare October 26, 2020 06:59
this will of course slow down analysis peformance, but should give us 
more correct analysis

it reveals the truth of lots of hidden false positives though ...
Repository owner deleted a comment from codecov-io Oct 28, 2020
Repository owner deleted a comment from codecov-io Oct 28, 2020
@aviatesk aviatesk closed this Oct 29, 2020
@aviatesk aviatesk reopened this Oct 29, 2020
@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #58 into master will decrease coverage by 0.71%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   83.71%   82.99%   -0.72%     
==========================================
  Files           9        9              
  Lines         792      794       +2     
==========================================
- Hits          663      659       -4     
- Misses        129      135       +6     
Flag Coverage Δ
#unittests 82.99% <69.23%> (-0.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/reports.jl 84.61% <ø> (-0.17%) ⬇️
src/abstractinterpretation.jl 94.57% <50.00%> (-2.28%) ⬇️
src/jetcache.jl 94.73% <100.00%> (+0.29%) ⬆️
src/JET.jl 40.50% <0.00%> (-3.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df15cbc...28f9a7e. Read the comment docs.

@aviatesk aviatesk merged commit f175a6e into master Oct 29, 2020
@aviatesk aviatesk deleted the avi/morecorrectcache branch October 29, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants