Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CodeInstance constructors #323

Closed
wants to merge 1 commit into from

Conversation

ianatol
Copy link

@ianatol ianatol commented Feb 19, 2022

Fixes #322 by accounting for recent CodeInstance constructor changes.

There's certainly more stuff needed (see #324), but this restores basic functionality like @report_opt 2+3

aviatesk added a commit that referenced this pull request Feb 21, 2022
@aviatesk aviatesk mentioned this pull request Feb 21, 2022
@aviatesk
Copy link
Owner

Thanks for having a look on this, Ian!
Now I think we can just remove the v"1.8.0-DEV.1484" ≥ VERSION ≥ v"1.8.0-DEV.1434" branch.
I'd like to merge #325 along with other fixes instead.

aviatesk added a commit that referenced this pull request Feb 21, 2022
aviatesk added a commit that referenced this pull request Feb 21, 2022
@ianatol ianatol deleted the ia/jeteffects branch March 1, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not compatible with Julia 1.8 dev
2 participants