"fix" the logic to call down into NativeInterpreter's abstract interpretation logic
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rpretation logic - previous `invoke_native` turns out to be really slow, e.g. we need to wait ~120 sec to `using StatsPlots; @profile_call density(rand(1000))`, while native JIT compilation only takes around ~7 sec for that - the new `@invoke_native` avoids runtime type constructions and maybe excessive code generation, and now we can profile on `density(rand(1000))` within 15 sec, which is vastly faster than current implementation
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 72.42% 72.75% +0.32%
==========================================
Files 10 10
Lines 671 679 +8
==========================================
+ Hits 486 494 +8
Misses 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invoke_nativeturns out to be really slow, e.g. we need towait ~120 sec to
using StatsPlots; @profile_call density(rand(1000)),while native JIT compilation only takes around ~7 sec for that
@invoke_nativeavoids runtime type constructions and maybeexcessive code generation, and now we can finish
@profile_call density(rand(1000))within 15 sec (note that this time includes IO overheads),
which is vastly faster than the previous implementation