Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no hacky overwriting of typeinf_local #10

Merged
merged 2 commits into from
Aug 28, 2020
Merged

no hacky overwriting of typeinf_local #10

merged 2 commits into from
Aug 28, 2020

Conversation

aviatesk
Copy link
Owner

@aviatesk aviatesk commented Aug 25, 2020

And the changes also remove the dirty overwriting of typeinf_local

@aviatesk aviatesk changed the title no hacky overwriting of typeinf_local and more accurate profiling by enabling optimization enable optimization, cache reports with internal code cache, accurate and faster profiling Aug 26, 2020
@aviatesk aviatesk force-pushed the avi/nohack branch 2 times, most recently from a4420df to 2312180 Compare August 27, 2020 08:56
@aviatesk aviatesk changed the title enable optimization, cache reports with internal code cache, accurate and faster profiling no hacky overwriting of typeinf_local Aug 28, 2020
@aviatesk
Copy link
Owner Author

okay, it turns out that enabling optimization (and thus integrating error reports with internal code cache) needs some work.
I would like to make this PR only remove the hacky overwriting of typeinf_local. Getting rid of that has one drawback that now we can't get "as much errors as possible" in a single gf call (e.g. fib("1000") in demo.jl) because native interpreter's typeinf_local early escape as soon as it uncovers Union{}. So for example now we only get 4 error reports for demo.jl, but it's acceptable imho because at least one error point would be reported for one toplevel gf call anyway. Apart from that, it is clearly better and preferable in terms of maintenance and performance.

@aviatesk aviatesk merged commit 8833a2d into master Aug 28, 2020
@aviatesk aviatesk deleted the avi/nohack branch August 28, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant