Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Transaction and Message immutable #156

Merged

Conversation

wiyarmir
Copy link
Member

@wiyarmir wiyarmir commented Nov 7, 2024

also tries to cleanup a bit the serialisation logic

@wiyarmir wiyarmir requested a review from jszmltr November 7, 2024 13:53
@wiyarmir wiyarmir force-pushed the guillermo/make-transaction-and-signedtransaction-immutable branch from 547d290 to cc54dbb Compare November 7, 2024 13:53
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

License Issues

settings.gradle.kts

PackageVersionLicenseIssue Type
io.github.oshai:kotlin-logging7.0.0NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
maven/io.github.oshai:kotlin-logging 7.0.0 UnknownUnknown
maven/io.github.oshai:kotlin-logging-jvm 7.0.0 UnknownUnknown

Scanned Files

  • settings.gradle.kts

Copy link
Contributor

github-actions bot commented Nov 7, 2024

😔 JUnit failed

Passed Failed Skipped
✅ 0 ❌ 0 ⚠️ 0

You can see the report here.

😔 JUnit failed

Passed Failed Skipped
✅ 0 ❌ 0 ⚠️ 0

You can see the report here.

😔 JUnit failed

Passed Failed Skipped
✅ 0 ❌ 0 ⚠️ 0

You can see the report here.

🥳 JUnit passed

Passed Failed Skipped
✅ 34 ❌ 0 ⚠️ 4

You can see the report here.

🥳 JUnit passed

Passed Failed Skipped
✅ 34 ❌ 0 ⚠️ 4

You can see the report here.

also tries to cleanup a bit the serialisation logic
@wiyarmir wiyarmir force-pushed the guillermo/make-transaction-and-signedtransaction-immutable branch from cc54dbb to cc04ae7 Compare November 7, 2024 13:58
@wiyarmir wiyarmir requested a review from jszmltr November 8, 2024 16:38
@wiyarmir wiyarmir enabled auto-merge November 12, 2024 09:00
@wiyarmir wiyarmir added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 396356f Nov 12, 2024
3 checks passed
@wiyarmir wiyarmir deleted the guillermo/make-transaction-and-signedtransaction-immutable branch November 12, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants