Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Non-standard repos #2734

Closed
wants to merge 1 commit into from
Closed

Conversation

yinggaozhen
Copy link
Contributor

@yinggaozhen yinggaozhen commented Sep 23, 2019

repo : https://github.com/robfig/bind
godoc.org : https://godoc.org/github.com/robfig/bind
go report : Go Report Card
maintenance : 2014-08-17
coverage service link :

  • coverall.io : Coverage Status
  • gocover.io : Test coverage
  • codecov : Coverage Status

reason for deletion :

  • : Missing godoc link
  • : Missing the readme
  • : Not updated or maintained for too long
  • : Test coverage does not meet the requirements
  • : The code quality is not high

repo : https://github.com/jyotiska/go-webcolors
godoc.org : https://godoc.org/github.com/jyotiska/go-webcolors
go report : Go Report Card
maintenance : 2015-08-21
coverage service link :

  • coverall.io : Coverage Status
  • gocover.io : Test coverage
  • codecov : Coverage Status

reason for deletion :

  • : Missing godoc link
  • : Missing the readme
  • : Not updated or maintained for too long
  • : Test coverage does not meet the requirements
  • : The code quality is not high

repo : https://github.com/ThePaw/probab
godoc.org : https://godoc.org/github.com/ThePaw/probab
go report : Go Report Card
maintenance : 2015-09-14
coverage service link :

  • coverall.io : Coverage Status
  • gocover.io : Test coverage
  • codecov : Coverage Status

reason for deletion :

  • : Missing godoc link
  • : Missing the readme
  • : Not updated or maintained for too long
  • : Test coverage does not meet the requirements
  • : The code quality is not high

repo : https://github.com/ian-kent/goose
godoc.org : https://godoc.org/github.com/ian-kent/goose
go report : Go Report Card
maintenance : 2014-12-21
coverage service link :

  • coverall.io : Coverage Status
  • gocover.io : Test coverage
  • codecov : Coverage Status

reason for deletion :

  • : Missing godoc link
  • : Missing the readme
  • : Not updated or maintained for too long
  • : Test coverage does not meet the requirements
  • : The code quality is not high

repo : https://github.com/rookii/paicehusk
godoc.org : https://godoc.org/github.com/rookii/paicehusk
go report : Go Report Card
maintenance : 2013-12-16
coverage service link :

  • coverall.io : Coverage Status
  • gocover.io : Test coverage
  • codecov : Coverage Status

reason for deletion :

  • : Missing godoc link
  • : Missing the readme
  • : Not updated or maintained for too long
  • : Test coverage does not meet the requirements
  • : The code quality is not high

repo : https://github.com/aybabtme/portproxy
godoc.org : https://godoc.org/github.com/aybabtme/portproxy
go report : Go Report Card
maintenance : 2014-12-13
coverage service link :

  • coverall.io : Coverage Status
  • gocover.io : Test coverage
  • codecov : Coverage Status

reason for deletion :

  • : Missing godoc link
  • : Missing the readme
  • : Not updated or maintained for too long
  • : Test coverage does not meet the requirements
  • : The code quality is not high

repo : https://github.com/ThePaw/go-gt
godoc.org : https://godoc.org/github.com/ThePaw/go-gt
go report : Go Report Card
maintenance : 2015-09-14
coverage service link :

  • coverall.io : Coverage Status
  • gocover.io : Test coverage
  • codecov : Coverage Status

reason for deletion :

  • : Missing godoc link
  • : Missing the readme
  • : Not updated or maintained for too long
  • : Test coverage does not meet the requirements
  • : The code quality is not high

repo : https://github.com/rdrdr/hamcrest
godoc.org : https://godoc.org/github.com/rdrdr/hamcrest
go report : Go Report Card
maintenance : 2011-02-15
coverage service link :

  • coverall.io : Coverage Status
  • gocover.io : Test coverage
  • codecov : Coverage Status

reason for deletion :

  • : Missing godoc link
  • : Missing the readme
  • : Not updated or maintained for too long
  • : Test coverage does not meet the requirements
  • : The code quality is not high

repo : https://github.com/tv42/mockhttp
godoc.org : https://godoc.org/github.com/tv42/mockhttp
go report : Go Report Card
maintenance : 2014-10-30
coverage service link :

  • coverall.io : Coverage Status
  • gocover.io : Test coverage
  • codecov : Coverage Status

reason for deletion :

  • : Missing godoc link
  • : Missing the readme
  • : Not updated or maintained for too long
  • : Test coverage does not meet the requirements
  • : The code quality is not high

repo : https://github.com/zach-klippenstein/goregen
godoc.org : https://godoc.org/github.com/zach-klippenstein/goregen
go report : Go Report Card
maintenance : 2016-03-04
coverage service link :

  • coverall.io : Coverage Status
  • gocover.io : Test coverage
  • codecov : Coverage Status

reason for deletion :

  • : Missing godoc link
  • : Missing the readme
  • : Not updated or maintained for too long
  • : Test coverage does not meet the requirements
  • : The code quality is not high

repo : https://github.com/beyang/hgo
godoc.org : https://godoc.org/github.com/beyang/hgo
go report : Go Report Card
maintenance : 2015-08-25
coverage service link :

  • coverall.io : Coverage Status
  • gocover.io : Test coverage
  • codecov : Coverage Status

reason for deletion :

  • : Missing godoc link
  • : Missing the readme
  • : Not updated or maintained for too long
  • : Test coverage does not meet the requirements
  • : The code quality is not high

repo : https://github.com/jimrobinson/kvbench
godoc.org : https://godoc.org/github.com/jimrobinson/kvbench
go report : Go Report Card
maintenance : 2014-04-20
coverage service link :

  • coverall.io : Coverage Status
  • gocover.io : Test coverage
  • codecov : Coverage Status

reason for deletion :

  • : Missing godoc link
  • : Missing the readme
  • : Not updated or maintained for too long
  • : Test coverage does not meet the requirements
  • : The code quality is not high

@kamilsk
Copy link
Contributor

kamilsk commented Sep 23, 2019

🔥

@ceriath
Copy link
Collaborator

ceriath commented Sep 23, 2019

Thanks a lot for doing this! Right now i unfortunately don't have the time to review all of it, but i defintiely will in the next few weeks

@yinggaozhen
Copy link
Contributor Author

yinggaozhen commented Sep 24, 2019

Thanks a lot for doing this! Right now i unfortunately don't have the time to review all of it, but i defintiely will in the next few weeks

Got it~

@appleboy
Copy link
Collaborator

Add maintainers @robfig @jimrobinson @beyang @zach-klippenstein @tv42 @rdrdr @ThePaw @jyotiska @ian-ken @rookii @aybabtme

@tv42
Copy link

tv42 commented Sep 25, 2019

Your definition of "standard" used here doesn't seem to match https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md

@yinggaozhen
Copy link
Contributor Author

yinggaozhen commented Sep 25, 2019

Your definition of "standard" used here doesn't seem to match https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md

as https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md

Tests, where practical. If the library/program is testable, then coverage should be >= 80% for non-data-related packages and >=90% for data related packages.

I found out from gocover. io that the current test coverage of your project is 68%, which does not meet the requirements.

and, the repo has not been maintained for a long time

@aybabtme
Copy link

i wonder why portproxy was there in the first place 🤪

@tv42
Copy link

tv42 commented Sep 26, 2019

@yinggaozhen You're missing the part about standard, as in "Non-standard documentation or Missing the readme". Also, please feel to remove everything written by me, these lists are silly.

@yinggaozhen
Copy link
Contributor Author

yinggaozhen commented Sep 26, 2019

@tv42 This is just something that I think is not very good, not official, so there will be review, it doesn't mean that these projects don't really meet the standards. Being removed doesn't really mean that the project is of poor quality, it just means that some indicators are temporarily not up to the standard. My intention is to promote the project maintainers to update and meet the standard as much as possible, not just to delete. In addition, I think the problem you mentioned is my fault, and I will adjust it. I'm sorry if anything hurt you.

@aybabtme
Copy link

@yinggaozhen im sure the effort is well meaning, but i think a problem with this approach is that many packages in this list have been added by people who weren't the authors of said package.

as a result, some people might feel it's a bit strange to be brought into a conversation about this, and to be "encouraged" to meet a standard for a list they never intended to join.

@yinggaozhen
Copy link
Contributor Author

@aybabtme

Yes, you're right. I think we can remind the author or the person who submitted it before we remove it. If they don't have enough time to change it, maybe we can remove it from the list, and add it back later when the author has time to fix it

@tv42
Copy link

tv42 commented Sep 27, 2019

@yinggaozhen At this point all I'm hearing is that the "rules" are arbitrary and up to your whims. More evidence that these lists are silly and not "awesome".

@yinggaozhen
Copy link
Contributor Author

yinggaozhen commented Sep 29, 2019

@tv42
You're right, this list doesn't look perfect, it might even make you feel "silly", that's why so many people are thinking about how to improve it and make it awesome(like #1446). of course Including this pull request.

But this PR seems that this has caused a lot of controversy. Maybe there is something wrong with the pull request itself, so I decided to close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants