This repository has been archived by the owner on Jan 27, 2020. It is now read-only.
Replaced off_t with int64_t in filemap.c for UNIX #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3rvac
approved these changes
May 19, 2018
There was a problem hiding this comment.
Thank you! This actually also solves an issue in avast/retdec#299 (this error to be more precise).
s3rvac
added a commit
to avast/yaracpp
that referenced
this pull request
May 19, 2018
This version contains a fix for the build of libyara under 32b Unix-like systems (see avast/yara#1).
s3rvac
added a commit
to avast/retdec
that referenced
this pull request
May 19, 2018
It contains a fix for a build issue on 32b Unix-like operating systems (avast/yara#1). This solves a build issue in #299.
|
Happy to help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RetDec couldn't be compiled with the
i686-linux-gnutoolchain sinceoff_tis 32bit and not 64. I forcedint64_ttype for UNIX systems so it can be compiled with a 32bit toolchain.