New build system #730
Merged
New build system #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows us to set it to ODD and build only documentation
When they are absolute, then all the paths in instaled cmake scripts are absolute - install dir could not be moved.
I have no idea why it doesn't work with PRIVATE.
1. Protect against including the same target file multiple times. It looks like this was not a problem, but who knows. 2. Use find_package() instead of find_dependency(). It looks like the later does not work correctly for components on some CMake versions.
Only the main RetDec version file is needed.
It is used to find the same version retdec components.
…ity settings Since we probably will make breaking changes, make retdec installation compatible only with the same version.
This reverts commit e1645d7.
Previous version should work, but there is a CMake bug in older versions which screws it up on Windows and macOS.
xkubov
pushed a commit
to radareorg/r2retdec
that referenced
this pull request
Apr 12, 2020
RetDec's Build system was refactored and introduced in pull request avast/retdec#730 This PR provided new way for building RetDec's libraries that is more convenient. There is no need to specify full paths of files of builded libraries.
xkubov
pushed a commit
to radareorg/r2retdec
that referenced
this pull request
Apr 12, 2020
RetDec's Build system was refactored and introduced in pull request avast/retdec#730 This PR provided new way for building RetDec's libraries that is more convenient. There is no need to specify full paths of files of builded libraries.
xkubov
pushed a commit
to radareorg/r2retdec
that referenced
this pull request
Apr 12, 2020
RetDec's Build system was refactored and introduced in pull request avast/retdec#730 This PR provided new way for building RetDec's libraries that is more convenient. There is no need to specify full paths of files of builded libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #648.
TeamCity will check that RetDec as a whole can be build on Linux, macOS, and Windows.
I also used https://github.com/avast/retdec-build-system-tests to check all the individual components on my Linux machine and our Linux servers. I partially did the same on our Windows server, but for some reason it is unable to compile OpenSSL and I was not able to solve that. It is not caused by these changes, it cannot do so even in
master- there is simply something wrong on that machine. I checked only the components that do not transitively depend on OpenSSL and it looks like it is OK. I have no macOS machine to manually do these tests, so we will look into potential problems once they are reported.