Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never try to limit memory on macOS #1074

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Never try to limit memory on macOS #1074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions src/utils/memory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace utils {

namespace {

#ifdef OS_POSIX
#if defined(OS_POSIX) && !defined(OS_MACOS)

/**
* @brief Implementation of @c limitSystemMemory() on POSIX-compliant systems.
Expand Down Expand Up @@ -115,10 +115,21 @@ std::size_t getTotalSystemMemoryOnMacOS() {
* @brief Implementation of @c limitSystemMemory() on MacOS.
*/
bool limitSystemMemoryOnMacOS(std::size_t limit) {
// Warning: We have found that limitSystemMemoryOnPOSIX() does not actually
// do anything on macOS. We need to find another way. See
// https://github.com/avast/retdec/issues/379
return limitSystemMemoryOnPOSIX(limit);
// Warning: We can't limit memory on macOS. Before macOS 12
// limitSystemMemoryOnPOSIX() does not actually do anything on macOS.
// Anyway, it just succeed, since macOS 12 it returns error and retdec can't
// start. See:
// - https://github.com/avast/retdec/issues/379
// - https://github.com/avast/retdec/issues/1045
//
// To be honest Apple can control memmory limit via so-called the ledger()
// system call which is private. An old verison which was opened to OpenSource
// (from 10.9-10.10?) using setrlimit() but at some point setrlimit() was broken
// and not ledger(). Probably at macOS 12 the setrlimit() was completley broken.
//
// Because we haven't got any other choose just return true which haven't
// change anything.
return true;
}

#elif defined(OS_BSD)
Expand Down