-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API for OpenSSL 3.0 #1041
Conversation
@PeterMatula Do we want to use OpenSSL 3.0 in |
@s3rvac I feel that the right way is requires the same Anyway all another part of |
From another hand I may easy add a few |
Here it is. Right now it just introduced a compatibility with OpenSSL 3 without broken anything :) |
@s3rvac I feel that I've overstep all your concern, am I wrong? |
Yes, thank you 🙂. I will leave the review to @PeterMatula. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I will trigger tests and if they pass I will merge.
Btw, these sources in deps
are in fact from here avast/authenticode-parser, but because we wanted to reduce the number of external deps, we decided to "inline" this simple repo in RetDec directly. But not to worry, @HoundThe can you please integrate these changes back to avast/authenticode-parser?
And a second task, @HoundThe can you look into the question of "different OpenSSL versions" opened here? I would like to know, where (what other parts) are we using OpenSSL, which versions, and if they can all deal with OpenSSL 3.0.
@PeterMatula thanks! Anyway, I'd love to share with you that v4.0 can't be build on system which has installed OpenSSL 3.0. Yes, it ships OpenSSL but system one is also used to build it. When your system has 1.x it is working, but with 3.0 => the hell is here. The way to fix it is trivial: catap@6aa99fe But it still, this patch need to be applied. v4.0 also can't be build on Apple M1 because of embeded OpenSSL version which is too old. And here I'd love to ask: maybe it is a good idea to release a new version? |
Here a minor changes in OpenSSL API.
Fixes: #1040