Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] project_budget: wizard to select budget date #172

Merged
merged 2 commits into from
Mar 4, 2019
Merged

[IMP] project_budget: wizard to select budget date #172

merged 2 commits into from
Mar 4, 2019

Conversation

oihane
Copy link
Contributor

@oihane oihane commented Mar 4, 2019

No description provided.

@codecov
Copy link

codecov bot commented Mar 4, 2019 •
edited
Loading

Codecov Report

Merging #172 into 11.0 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             11.0     #172      +/-   ##
==========================================
+ Coverage   99.91%   99.91%   +<.01%     
==========================================
  Files          71       72       +1     
  Lines        1204     1220      +16     
==========================================
+ Hits         1203     1219      +16     
  Misses          1        1
Impacted Files Coverage Δ
project_budget/wizards/project_initial_budget.py 100% <100%> (ø)
project_budget/models/project_project.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3922e2b...d8d2bc5. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 4, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.001%) to 99.918% when pulling d8d2bc5 on oihane:11.0-budget into 3922e2b on avanzosc:11.0.

@oihane
Copy link
Contributor Author

oihane commented Mar 4, 2019

@avanzosc/developers ready for review

alfredoavanzosc
alfredoavanzosc approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@alfredoavanzosc alfredoavanzosc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oihane oihane merged commit 3d08a42 into avanzosc:11.0 Mar 4, 2019
@oihane oihane deleted the 11.0-budget branch March 4, 2019 14:44
oihane added a commit to oihane/project-addons that referenced this pull request Dec 2, 2019
@oihane
[IMP] project_budget: wizard to select budget date (avanzosc#172)
a3fbe59 
* [IMP] project_budget: wizard to select budget date

* [IMP] project_budget: improve test
oihane added a commit to oihane/project-addons that referenced this pull request Mar 9, 2022
@oihane
[IMP] project_budget: wizard to select budget date (avanzosc#172)
547aadc 
* [IMP] project_budget: wizard to select budget date

* [IMP] project_budget: improve test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfredoavanzosc alfredoavanzosc alfredoavanzosc approved these changes

@Daniel-CA Daniel-CA Daniel-CA approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oihane @coveralls @Daniel-CA @alfredoavanzosc