Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend playlist items container height fully on mobile devices #5623

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

Dananji
Copy link
Contributor

@Dananji Dananji commented Feb 2, 2024

Related issue: #5589

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine enough as is. My question doesn't need to block merging.

Comment on lines +53 to +54
const USER_AGENT = window.navigator.userAgent;
const IS_MOBILE = (/Mobi/i).test(USER_AGENT);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to import Ramp's mobile checking and use it here?

@Dananji Dananji merged commit a74dc68 into develop Feb 2, 2024
2 checks passed
@Dananji Dananji deleted the playlist-items-height branch February 2, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants