Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include original supplemental filenames in iiif manifest #5599

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

masaball
Copy link
Contributor

@masaball masaball commented Jan 25, 2024

This PR adds an entry to the label field for caption and transcript files so that the original filename can be serialized into the manifest. We serialize the user-defined label into the manifest first, using the language as its key. Then we serialize the original filename without a key.

This will allow us to differentiate the names to facilitate better file handling within the Ramp file downloader.

@masaball masaball requested a review from cjcolvar January 30, 2024 15:02
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good!
I'm a little concerned about putting two different values that don't have equivalent semantics in the same IIIF field, but we can think about that in another issue.

@masaball masaball merged commit b3deca1 into develop Jan 31, 2024
@masaball masaball deleted the original_transcript_name branch January 31, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants