Fix "Create Timeline" actions #5578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were three separate bugs: 1. Items without structure were not assigning any value to `streamID`, preventing the proper creation route being generated. 2. The if/else block for handling custom scopes was not successfully assigning values to the `id` variable when a custom scope was selected. 3. Custom scopes were not converting into the right time format for timeliner to parse, so the timeline would be created but would not be limited to the time range defined by the custom scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were three separate bugs:
streamID, preventing the proper creation route url being generated.idvariable when a custom scope was selected.