Disable transcript tab when there are no transcripts #5574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original implementation only hid the transcript tab. This resulted in a user being able to navigate to the tab content via arrow key navigation. We can prevent this by adding `disabled` to the class of the tab.
cjcolvar
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
This looks good to me, but I'm wondering if a screen reader will still be trying to read the transcript tag and we might need to set aria-disabled or aria-hidden. I'm not quite sure how to test this unless the SiteImprove browser extension would flag it due to the inconsistency.
|
Browserstack has a screen reader on at least the chrome browsers. Just tested there and the screen reader did not read out the transcript tab with just the hidden and disabled flags provided and siteimprove browser plugin did not flag anything. So I think we are good accessibility wise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original implementation only hid the transcript tab. This resulted in a user being able to navigate to the tab content via arrow key navigation. We can prevent this by adding
disabledto the class of the tab.