Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set tabbed nav columns to fill height #5572

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Set tabbed nav columns to fill height #5572

merged 1 commit into from
Jan 17, 2024

Conversation

Dananji
Copy link
Contributor

@Dananji Dananji commented Jan 12, 2024 •
edited
Loading

Details tab with overflowing content:
Details_tab_no-overflow

Details tab with no overflowing content:
Details_tab_overflow

Transcripts tab with no overflowing content:
Transcripts_tab_no-overflow

Transcripts tab with overflowing content:
Transcripts_tab_overflow

Files tab with no overflowing content:
Files_tab_not-overflow

Related issue: #5498

cjcolvar
cjcolvar approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as far as I can tell.

@Dananji Dananji merged commit bd051b8 into develop Jan 17, 2024
2 checks passed
@Dananji Dananji deleted the tabbed-nav-columns branch January 17, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @cjcolvar