Fix copy timeline modal actions #5569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. I'd forgotten about/missed that fix. Definitely a better approach. I'm near the end of my day, but I'll update this PR tomorrow. Thanks! |
masaball
force-pushed
the
timeline_copy
branch
from
3616385 to
bcdd05b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5528
The code handling the submit action for copying timelines was looking for attributes from the
datavariable but the copy action did not have that variable populated.Added safe navigation for the error check and changed the redirect link to be pulled from the event variable.Changed the variable assignment to populate fromevent.detail.