Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only return link html if website url present #5560

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Only return link html if website url present #5560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/presenters/collection_presenter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def contact_email
end

def website_link
view_context.link_to document["website_label_ssi"], document["website_url_ssi"] unless document["website_url_ssi"].nil?
view_context.link_to document["website_label_ssi"], document["website_url_ssi"] if document["website_url_ssi"].present?
end

def as_json(_)
Expand Down
8 changes: 8 additions & 0 deletions spec/presenters/collection_presenter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,14 @@
expect(presenter.website_link).to be_nil
end
end

context 'with a blank website url' do
let(:website_url) { '' }

it 'returns null' do
expect(presenter.website_link).to be_nil
end
end
end

describe '#as_json' do
Expand Down