Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoke transcript switch on player ready event #5551

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Invoke transcript switch on player ready event #5551

merged 1 commit into from
Jan 9, 2024

Conversation

Dananji
Copy link
Contributor

@Dananji Dananji commented Jan 8, 2024

Trigger transcript tab show/hide on VideoJS player's player.ready event instead of player.loadedmetadata event which takes longer to fire with HLS streaming.

masaball
masaball approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Dananji Dananji merged commit 5b186c2 into develop Jan 9, 2024
2 checks passed
@Dananji Dananji deleted the transcript-switch branch January 9, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masaball masaball masaball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @masaball