Return array of ids for SpeedyAF::Proxy::MediaObject.sections_with_files #5547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masaball
changed the title
cjcolvar
reviewed
Jan 5, 2024
cjcolvar
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transcript check function to hide/display the transcript tab has been broken for a little bit. This was caused by the media object presenter returning an array of full master files from the
#sections_with_filesmethod instead of an array of master file IDs which is what should be getting returned. This discrepancy caused the check of the active section ID against the list of sections with files to always fail, thus never rendering the transcript tab.