Store http sources as tempfiles on disk to avoid issue with ffmpeg blocking #5546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I can tell this doesn't break things on avalon-dev but as mentioned above it probably isn't using the new code since it is backed by minio. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at resolving the issue with intercom push spawning WaveformJobs which run for hours.
Note: While testing I noticed that in the docker development environment the ffmpeg command for streaming urls doesn't work because of localhost not resolving. This shouldn't be a problem in IU's production environment and probably won't be an issue at all because preference is given to using derivative files which are available via minio in the docker environment. I wanted to mention this in case we find a scenario where it is an issue in the future.