Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to playlist changes #5538

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Add to playlist changes #5538

merged 3 commits into from
Dec 21, 2023

Conversation

masaball
Copy link
Contributor

This PR:

  • Changes the phrasing for the manually defined timespan option
  • Provides a default selection based on whether the current timespan is within a track/subsection or not

cjcolvar
cjcolvar previously approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell.

Dananji
Dananji approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@Dananji Dananji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@masaball masaball merged commit c7aaccc into develop Dec 21, 2023
@masaball masaball deleted the add_to_playlist_changes branch December 21, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dananji Dananji Dananji approved these changes

@cjcolvar cjcolvar cjcolvar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masaball @cjcolvar @Dananji