Add safe navigator to captions check #5512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encountered an issue on avalon-dev where `@master_file.captions` returned nil instead of an empty Indexed file so the subsequent check for content errored. This prevents the HLS manifest from generating, causing streaming to fail. I think this will be encountered with any item created after we changed how captions are created/stored. Adding the safe navigator should take care of the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered an issue on avalon-dev where
@master_file.captionsreturned nil instead of an empty Indexed file so the subsequent check for content errored. This prevents the HLS manifest from generating, causing streaming to fail. I think this will be encountered with any item created after we changed how captions are created/stored. Adding the safe navigator should take care of the issue.