Move playlist action buttons out of ramp context #5511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Copy Playlist" button relies on some functions which do not trigger/interact properly when the buttons are being rendered by/within the Ramp context. Rather than try to get the functions to interact with Ramp properly or move the functions into the Ramp context, it felt simpler to pull the buttons back out of Ramp. This has the added benefit(?) of bringing the page styling closer inline with the non-Ramp based playlist show page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Copy Playlist" modal relies on some functions which do not trigger/interact properly when the buttons are being rendered by/within the Ramp context. Rather than try to get the functions to interact with Ramp properly or move the functions into the Ramp context, it felt simpler to pull the action button partial back out of Ramp. This has the added benefit(?) of bringing the page styling closer inline with the non-Ramp based playlist show page.