Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only look at language code when de-duping during bib import #5510

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented Dec 6, 2023

Fixes https://github.iu.edu/AvalonIU/Avalon/issues/193

In production we encountered a bib import that supplied both the language code and text as part of the MODS. This lead to problems in the import code since self.language returns the whole language block which includes both code and text. This PR changes this to look at only the language code since this is all that typically comes through our SRU service.

For example:

<language>
  <languageTerm type="code" authority="iso639-2b">eng</languageTerm>
  <languageTerm type="text">English</languageTerm>
</language>

versus

<language>
  <languageTerm type="code" authority="iso639-2b">eng</languageTerm>
</language>

Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cjcolvar cjcolvar merged commit 95dd5af into develop Dec 8, 2023
@cjcolvar cjcolvar deleted the bib_import_lang branch December 8, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants