Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not change playlist item title on media end #5506

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

masaball
Copy link
Contributor

@masaball masaball commented Dec 5, 2023

The original implementation changed the playlist item title to "Inaccessible item" on video end as a workaround for when the next autoplay playlist item was inaccessible. This is because the title does not otherwise update when an item has a blank canvas. This workaround was insufficient and caused unintended behavior when autoplay was not on. Issues with item title not updating will be handled in #5497.

The original implementation changed the playlist item title to
"Inaccessible item" on video end as a workaround for when the next
autoplay playlist item was inaccessible. This is because the title
does not otherwise update when an item has a blank canvas. This
workaround was insufficient and caused unintended behavior when autoplay
was not on. Issues with item title not updating will be handled in #5497.
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@masaball masaball merged commit 440c972 into develop Dec 7, 2023
@masaball masaball deleted the ramplist branch December 7, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants