Cleanup ME.js code in JS, CSS, HTML files, remove SVG #5492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
reviewed
Dec 12, 2023
There was a problem hiding this comment.
There are 6 failing tests that call the PlaylistItemsController#markers action and fail because app/views/playlist_items/_markers.html.erb was deleted. We'll either need to remove that route, change what it returns, or restore the partial. If it isn't called anywhere else and was only used to supply the UI then I'd favor removing it. If we do that then I'd think the source_details and related_items actions could be removed too.
|
I think the |
Dananji
force-pushed
the
mejs-cleanup
branch
from
86e6c72 to
52cbd96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.