Replace playlist show page player with Ramp #5472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix in Ramp: samvera-labs/ramp#292 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Work left to do:
Current playlist item title should be displayed below playerSource item details panel needs to be added(Parsing will be brought in as part of future Ramp build. See Ramp #252)Panels below player (source item, markers, related items) should be collapsibleIndicator in structured nav for currently selected item(Will be brought in with next ramp build)Also, maybe the edit/copy buttons should be pulled back out of the Ramp context? If they are outside of the Ramp context, we could put them level with the title and then the autoplay and share buttons would be level with the player which is closer to how the page is currently set up.