Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display transcript and file tabs when none are present #5466

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

masaball
Copy link
Contributor

No description provided.

Copy link
Contributor

@Dananji Dananji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! 👍

This is not something to do in this PR, I think we should probably consolidate all the player listener code for create timeline, create thumbnail, add to playlist, share, and this into one place. There's a lot of the same code in multiple places for these templates.

@cjcolvar cjcolvar merged commit 3f6a6b1 into develop Nov 15, 2023
@cjcolvar cjcolvar deleted the vanish_tabs branch November 15, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants