Bug fixes for persisting user edits and enable/disable current track option in add to playlist #5465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…option in add to playlist
cjcolvar
approved these changes
Nov 14, 2023
Comment on lines
+233
to
+235
| let trackName = activeTrack.tags.includes('current-section') | ||
| ? activeTrack.label || streamId | ||
| : `${currentSectionLabel} - ${activeTrack.label || streamId}`; |
There was a problem hiding this comment.
There is kind of a lot going on here logically. Would it make sense to break this down into multiple lines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a current track is not available:
When a current track is available:
When there's no structure (current section has <media_object.id - master_file.id>):
